Attention is currently required from: laforge, msuraev.
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1d/+/30023 )
Change subject: doxygen API documentation for libosmo-e1d
......................................................................
Patch Set 5:
(4 comments)
Patchset:
PS5:
Doc looks good except for the few comments.
File src/proto_clnt.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/a3a1755d_c51af873
PS5, Line 230: * \returns zero in case of success; negative in case of error. */
Maybe specify E1DP_INVALID can be specified to get info about all the interfaces ?
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/961ccc74_58d8a146
PS5, Line 267: * \param[in] line E1 line number (within interface) to query.
Again, here 'line' is optional and can be E1DP_INVALID to get info about all the
lines of the interface
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/1019ace8_cc1d6159
PS5, Line 306: * \param[in] ts E1 timeslot numer (within line) to query.
Same ts can be E1DP_INVALID to get all ts of that line on that interface
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1d/+/30023
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b
Gerrit-Change-Number: 30023
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 06 Nov 2022 21:38:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment