Attention is currently required from: pespin, fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31126
)
Change subject: abis_rsl: add ericsson specific paging group IE to
rsl_ericsson_imm_assign_cmd
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31126/comment/e837b931_4b6e194b
PS3, Line 484: extract_paging_group
> Paging group is needed when sending Immediate
Assignment over PCH. […]
I am a bit puzzled as well here but I think I remember now.
There was the problem with the DL TBF and sending the Immediate Assignment via PCH solved
it. So the Immediate assignment here goes through the PCH and not through the AGCH. I have
corrected this here for now.
The SAPI PCU_IF_SAPI_AGCH_DT is not used in osmo-pcu.git, thats correct. The patch is
still in review, see: I2a78651593323e8b9627c39918d949a33497b70f - but as far as I can see
it also still uses the wrong terminology s/AGCH/PCH.
Its the case that we have to use an ericsson proprietary way to handle this. Unfortunately
the code seems to be a bit out of place now. Maybe we should add a SAPI
PCU_IF_SAPI_PCH_ERIC or so that handles this. I am not entirely sure.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31126
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99
Gerrit-Change-Number: 31126
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 01 Feb 2023 16:09:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment