Change in osmo-bsc[master]: Rearrange ctrl interface code

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29631 ) Change subject: Rearrange ctrl interface code ...................................................................... Patch Set 1: (11 comments) File src/osmo-bsc/bsc_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-919): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/36db8ab4_ddad114a PS1, Line 371: struct gsm_network *net = (struct gsm_network*)cmd->node; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-919): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/9d4e4f08_97cdc947 PS1, Line 392: struct gsm_network *net = (struct gsm_network*)cmd->node; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-919): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/6513551f_6090f5fe PS1, Line 670: * transferred, to permit caller to send the same CMD to several ASPs. please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-919): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/7b98b697_43e249d3 PS1, Line 671: * Caller must hence free 'cmd' itself. please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-919): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/9c5d3f4a_620c205c PS1, Line 857: } adding a line without newline at end of file File src/osmo-bsc/bts_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-919): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/ed99f7cc_a922ca8a PS1, Line 70: LOGP(DCTRL, LOGL_DEBUG, "Found %i positions.\n", i); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-919): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/7f343594_1b56d180 PS1, Line 87: cmd->variable = talloc_asprintf(cmd, "bts.%i.location-state", bts->nr); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-919): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/86f67e3c_d4156d95 PS1, Line 129: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-919): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/e032abf9_c11f82aa PS1, Line 649: rc =bsc_bts_trx_ctrl_cmds_install(); spaces required around that '=' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-919): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/ac3b4768_2391fc11 PS1, Line 652: } adding a line without newline at end of file File src/osmo-bsc/bts_trx_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-lint-919): https://gerrit.osmocom.org/c/osmo-bsc/+/29631/comment/31000e36_ffbb39ae PS1, Line 119: } adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I51a9b31780a4a8026aafb2d732369cdc10c8bb70 Gerrit-Change-Number: 29631 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 05 Oct 2022 13:43:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment