Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28862 )
Change subject: trxcon: rework trxcon_inst cleanup logic, add trxcon_fsm_pre_term_cb() ......................................................................
Patch Set 1:
(1 comment)
File src/host/trxcon/src/trxcon.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28862/comment/f7368b9e_09d25206 PS1, Line 270: /* Reparent trxcon_inst from ctx to trxcon->fi */ Here again, reparenting makes everything more convoluted and difficult to follow imho, and must be used only if there's a really good reason, because if you start using it everywhere like this it ends up being difficult to follow the dependency chain, since usually one simply looks at the talloc() call.