Change in osmo-ci[master]: obs: add explicit --git-branch arg

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29116 ) Change subject: obs: add explicit --git-branch arg ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: Personally I would find a --git-no-checkout argument more useful, which would for already cloned repositories simply not checkout and reset the branch. This has the advantage that one doesn't need to push to a remote git server first and then fetch and checkout as described in your README, but one could just directly edit the files in the cache directory. But I get the downside, that one is then working in two repository directories. So if this is more useful to you, let's add it. (And maybe I'll add the other option in another patch when I need it.) File scripts/obs/lib/__init__.py: https://gerrit.osmocom.org/c/osmo-ci/+/29116/comment/bb520a01_c7e185e2 PS1, Line 20: " named like the feed, checkout this git branch", by default the branch isn't always named like the feed: feed latest -> latest tag feed nightly -> master feed 2022q1 etc. -> 2022q1 so I'd change "named like" in this help string to "based on" File scripts/obs/lib/srcpkg.py: https://gerrit.osmocom.org/c/osmo-ci/+/29116/comment/d1c198be_85a2c303 PS1, Line 125: branch = feed this breaks the logic of checkout_for_feed, if the feed is latest or nightly it isn't the branch name. it should work as expected when just removing the "if not branch:" and "branch = feed" lines https://gerrit.osmocom.org/c/osmo-ci/+/29116/comment/8ab3476e_a6461c13 PS1, Line 139: unrelated -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I612c18e533542f442e0571927fee8b8be9fb8c2b Gerrit-Change-Number: 29116 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 09:00:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment