Attention is currently required from: Hoernchen.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30633 )
Change subject: logging: add log level cache
......................................................................
Patch Set 2:
(3 comments)
File src/logging.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1999):
https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/adeb9050_702a0480
PS2, Line 101: static void log_cache_update_all()
Bad function definition - void log_cache_update_all() should probably be void
log_cache_update_all(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1999):
https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/584c2cfc_22ebdeec
PS2, Line 110: llist_for_each_entry (tgt, &osmo_log_target_list, entry) {
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1999):
https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/3786fff4_73033842
PS2, Line 131: llist_for_each_entry (tgt, &osmo_log_target_list, entry) {
space prohibited between function name and open parenthesis '('
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30633
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d
Gerrit-Change-Number: 30633
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Dec 2022 16:09:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment