Attention is currently required from: laforge.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/32655
)
Change subject: Support (optional) indication of NCH position in SI1 rest octets
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/32655/comment/abb21d3b_a1aada6e
PS2, Line 1113: "nch-position num-blocks <1-7> first-block <0-6>",
These are actually 5 arguments, but here are only 3 descriptions of them.
https://gerrit.osmocom.org/c/osmo-bsc/+/32655/comment/9b8c1b1b_f8054e66
PS2, Line 1114: "NCH (Notification Channel) position within CCCH"
Missing \n to separate descriptions.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/32655
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iefde0af44a663f22462a54d68a58caa560eceb2f
Gerrit-Change-Number: 32655
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 08 May 2023 08:14:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment