6 Mar
2023
6 Mar
'23
1:33 p.m.
Attention is currently required from: fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31669 )
Change subject: gsm0502: add burst length definitions from chapter 5.2 ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File include/osmocom/gsm/gsm0502.h:
https://gerrit.osmocom.org/c/libosmocore/+/31669/comment/4f3622ae_e662fa06 PS1, Line 36: #define GSM_NBITS_NB_GMSK_PAYLOAD 2 * 58 you should have braces around that operation, at least for preproc constants. If it was an enum, no braces required =)
Same everywhere below when it has operators involved.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31669
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1c38ccc2b64ba9046bb3b1221d99cc55ec493802
Gerrit-Change-Number: 31669
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 06 Mar 2023 02:33:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment