Attention is currently required from: Jolly.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/30450 )
Change subject: Send raw data with mISDN as it arrives from application
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
Are you sure this won't break any existing applications? So far we did not push this
responsibility into applications. An application can just enqueue data into the write
queue, and it's the responsibility of e1_input to sned it with the speed that the
driver/hardware/network supports.
For DAHDI and osmo-e1d, we have file descriptors (device node, unix domain socket) which
simply block once the transmit buffer is full and the line is not consuming data at the
rate that is arriving from the application. So the flow/rate is controlled by the file
descriptor becoming write-able.
And exactly this is where mISDN differs, and libosmo-abis/e1_input needs to ensure the
same semantics towards the application.
marking as -1 until we are absolutely certain
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/30450
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ib311331fbbeff3661f6745e3474918987a8aa460
Gerrit-Change-Number: 30450
Gerrit-PatchSet: 1
Gerrit-Owner: Jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 05 Dec 2022 08:43:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment