Attention is currently required from: pespin, dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606 )
Change subject: PCUIF_Types: add record PCUIF_pch_dt
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File library/PCUIF_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606/comment/dea5f65b_0971…
PS2, Line 319: octetstring
I have changed it to charstring now
Thanks.
but I also saw IMSI as octetstring in some places
If we go for octetstring, we would have to convert between `octetstring` and `charstring`
when sending and receiving PCUIF PDUs. This is inconvenient and limits matching
capabilities.
It also appears also sometimes heckstring
`hexstring` you mean? This is for BCD encoding, which is not the case here.
P.S. hex the planet!
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia705d3a6fe7adb863acd29e968f8dc6b2066a497
Gerrit-Change-Number: 32606
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 10 May 2023 16:53:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment