[M] Change in libosmo-netif[master]: ipa: Add segmentation callback

Attention is currently required from: arehbein, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33652 ) Change subject: ipa: Add segmentation callback ...................................................................... Patch Set 3: (2 comments) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/70b6a133_4b2a4a82 PS2, Line 378: MSG_CB_IPA_PROTO_EXT_IS_SET_OFFSET We wouldn't need the IS_SET flag anyway, I'd expect proto_ext to only have a meaning if proto is IPAC_PROTO_OSMO. I like the idea of a packed struct, that way we only use up one cb for both proto and proto_ext. I think it would help to have macros to set/get proto/proto_ext from a msgb and use those. ``` struct osmo_ipa_info { uint8_t proto; uint8_t proto_ext; } __attribute__ ((packed)); #define OSMO_IPA_SET_INFO(msg, proto, proto_ext) \ do { \ struct osmo_ipa_info info = { .proto = proto, .proto_ext = proto_ext, }; (msg)->cb[0] = info;\ } while (false) ``` https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/0f58a2d7_4f942db7 PS2, Line 432: /* Below: Helper functions for addition of send_ipa functionality in later commit */ Iirc the idea was to introduce ipa_check_pull_headers() AND use it in the segmentation_cb(). The other functions can go in a later commit where they are needed. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I87ef4c7023126b783dd79e7ed47be31e1b76f975 Gerrit-Change-Number: 33652 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jul 2023 14:41:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment