[M] Change in osmo-ttcn3-hacks[master]: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email ) Change subject: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/65f0bd93_2302… PS2, Line 26: ": " token in the value. I'd expect TEXT decoder to put all subsequent pleas do make sure to report each of those to the eclipse TITAN forum. They might either be genuine bugs, or there might be users with [other] solutions to the problems you're facing. File asterisk/AMI_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/f4e087d6_aead… PS2, Line 189: welcome_str := "Asterisk Call Manager/9.0.0\r\n" wouldn't this better be a regex? so that code could match multiple different versions, or ignore versions altogether? You could rename welcome_str to welcome_str_pattern and then use it as a regex (using the "referenced" notation of TTCN3 regex where you can interpret a string as a regex). Not critical, just a thought while reading this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icaf2860c1dd4befa4498f0d176cfadf26cfa8d1d Gerrit-Change-Number: 36755 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 May 2024 08:15:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment