Attention is currently required from: daniel.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32759 )
Change subject: [WIP] osmo_io: Support detecting connect
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/32759/comment/4a9c9031_8cdb0a8f
PS1, Line 13: osmo_iofd_write_enable() so that if called and the write queue is empty
please rephrease this, I don't understand.
File src/core/osmo_io_poll.c:
https://gerrit.osmocom.org/c/libosmocore/+/32759/comment/26236227_9432b01a
PS1, Line 114: if (iofd->mode == OSMO_IO_FD_MODE_READ_WRITE)
some comment like: /* socket becomes writeable butno message to be sent. This happens
usually during async connect()) */
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32759
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I893cbc3becd5e125f2f06b3654578aed0aacadf3
Gerrit-Change-Number: 32759
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 May 2023 15:32:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment