Attention is currently required from: pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/33091 )
Change subject: libosmogsm: Allow auth API caller to specify RES length
......................................................................
Patch Set 3:
(2 comments)
File src/gsm/auth_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/33091/comment/00830b5e_235ffc40
PS3, Line 224: if (aud->type == OSMO_AUTH_TYPE_UMTS) {
I think this should go inside auth_data2auth_data2(),
since v2 users are expected to set it always.
note this is modifying the *vec*, not
the *aud*. So I cannot do it in auth_data2auth_data2 where I only have access to the aud,
but not to the vec.
https://gerrit.osmocom.org/c/libosmocore/+/33091/comment/45459518_cd5484a5
PS3, Line 301: if (aud->type == OSMO_AUTH_TYPE_UMTS) {
Add to auth_data2auth_data2, you can drop it from
here.
see above, doesn't work.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/33091
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef
Gerrit-Change-Number: 33091
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 30 May 2023 19:29:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment