Attention is currently required from: pespin.
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/33970
to look at the new patch set (#2).
Change subject: sm: Introduce APIs to enc/dec QoS Profile
......................................................................
sm: Introduce APIs to enc/dec QoS Profile
Ported from open5gs.git/lib/gtp/v1/types.{c,h} 5764f7267d16a8ea6aeedc6c227552575915def5,
for which I was the author too.
The ARP extra byte field at the start of the IE val which is introduced in the
GTP variant is dropped when porting to SM, since it's not present there
(and offsets/sizes are adjusted).
The QoS code is moved is moved into a common/ directory where a new
libosmo-gprs-common.la private static library is created.
This is done in order to be able to resuse the QoS dec/enc code in
several libraries since it's actually planned to use it in SNDCP and SM
layers.
The most natural place to add the APIs is SM, and that's where the
public API to accees the enc/dec is provided, since the user app will
have to use them in the SM SAP.
However, the SNDCP will also have to decode the QoS recived by SM
through the SNSM SAP, and we don't really want libosmo-gprs-sndcp depend
on libosmo-gprs-sm. This way libosmo-gprs-sndcp will be able to use the
private APIs directly in a follow-up commit.
Change-Id: I6c0676e55bb1f0f424f41d8d04d4f5e5bf376f4f
---
M configure.ac
M include/osmocom/gprs/sm/Makefile.am
M include/osmocom/gprs/sm/sm.h
A include/osmocom/gprs/sm/sm_qos.h
M src/Makefile.am
A src/common/Makefile.am
A src/common/qos.c
A src/common/qos.h
M src/sm/Makefile.am
A src/sm/sm_qos.c
10 files changed, 503 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/70/33970/2
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/33970
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I6c0676e55bb1f0f424f41d8d04d4f5e5bf376f4f
Gerrit-Change-Number: 33970
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset