Attention is currently required from: iedemam.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27081
)
Change subject: stats: new trackers for lchan life duration
......................................................................
Patch Set 13:
(1 comment)
File src/osmo-bsc/lchan_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/73baf37b_329c50ef
PS13, Line 226: lchan->activate.timekeeper = (struct osmo_time_cc){
also you probably want to do this only once during lchan allocation, i.e. in
lchan_fsm_alloc(), or in ts_setup_lchans() in timeslot_fsm.c. Either one is fine.
That's because you want to accumulate the active time across multiple lchan
activations. The only thing remaining here in this function should be setting the flag to
true.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27081
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347
Gerrit-Change-Number: 27081
Gerrit-PatchSet: 13
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: iedemam <michael(a)kapsulate.com>
Gerrit-Comment-Date: Thu, 03 Mar 2022 18:06:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment