Attention is currently required from: laforge, pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915 )
Change subject: immediately SCCP RLSD on HNB re-register
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
iiuc MAP_RUA_ST_DISCONNECTED means the CN side is
down, and MAP_RUA_ST_DISRUPTED means the RAN side […]
ST_DISCONNECTED means we
received a RUA Disconnect message.
ST_DISRUPTED means the HNB has stopped responding for whatever reason. The RUA connection
is just gone without a graceful RUA Disconnect message. We noticed that and need to clean
up.
I tried to explain in the commit msg...
File src/osmo-hnbgw/context_map_sccp.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915/comment/effd0a12_fa1cc689
PS1, Line 362: tx_sccp_df1(fi, ranap_msg);
: tx_sccp_rlsd(fi);
it's a bit odd to see code here that naming-wise
claims to directly transmit protocol meassages like […]
I understand the
"tx" as "send down the user SAP", not necessarily transmit on a wire.
In this particular instance, there will actually be an SCCP RLSD message sent on the wire,
which is the point of this patch. If a RUA conn is gone without telling the CN via RANAP
Iu Release, then osmo-hnbgw will tell the CN via immediate SCCP RLSD message.
If you think this name should be changed, i'm open to that. let's do that in a
separate patch.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I4e78617ad39bb73fe92097c8a1a8069da6a7f6a1
Gerrit-Change-Number: 32915
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 24 May 2023 01:39:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment