Attention is currently required from: pespin, dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/33522 )
Change subject: pcu_sock: use PCUIF version 11 (direct TLLI)
......................................................................
Patch Set 1:
(1 comment)
File src/common/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33522/comment/70aad5e5_eb5edbe2
PS1, Line 635: pcu_prim->u.data_cnf_dt = (struct gsm_pcu_if_data_cnf_dt) {
iiuc this makes osmo-bts defacto only use the new
SAPI, and hence only work properly against an osmo-pcu using/supporting PCUIF 11.
This has always been the case when bumping the PCUIF protocol version.
IMHO, osmo-bts should store info on which SAPI was
used to send the PDH_DATA.req and then use thew old or new SAPI based on that, to stay
compatible against older osmo-pcu.
IMO, this is unnecessary complication. I would even go for removing the old TLLI-less
messages/structures completely and having only the PCUIFv11 stuff in osmo-bts.git, while
keeping backwards compatibility in osmo-pcu.git. It's the first time we're aiming
to stay backwards compatible, and see how many weeks it's already taking too finish
this. Let's avoid complicating/delaying it even further.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/33522
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I25816ac12e63cc6b641eb414e6bc7eaa9c85fc25
Gerrit-Change-Number: 33522
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Jun 2023 11:01:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment