Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30761 )
Change subject: isdndlc: Fix documentation ......................................................................
Patch Set 1:
(7 comments)
File src/isdnhdlc.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2209): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/b1761bb5_d67bf55d PS1, Line 100: excluding the CRC. please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2209): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/660bc39a_6c34ea2c PS1, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2209): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/e39e5dc3_f6da3b8a PS1, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. Avoid multiple line dereference - prefer 'CRC.returns'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2209): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/a9a4ca68_d62059a6 PS1, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2209): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/5c4cd1db_3d43d06c PS1, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2209): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/0df3ec7d_acc0f465 PS1, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. Avoid multiple line dereference - prefer 'OSMO_HDLC_FRAMING_ERROR.If'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2209): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/34ca20d5_29156c18 PS1, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)