Attention is currently required from: mschramm, roh.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-remsim/+/33812 )
Change subject: log at NOTICE level if somebody uses loopback addresses.
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File src/client/main_fsm.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/33812/comment/62e55518_1f10ce37
PS2, Line 252: LOGPFSML(fi, LOGL_NOTICE, "we were instructed to connect to a bankd
on a loopback address "
: "%s. This is most likely a BROKEN CONFIGURATION, unless this
client runs on the "
: "same host as remsim-bankd\n",
bc->bankd_conn.server_host);
we can actually be smarter about this message (on the client side): Only log this message
if we ourselves are also using a loopback address. This way no NOTICE messages are
printed when somebody actually does run bankd+client on localhost (which works). you just
cannot run one on non-localhost and the other on it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-remsim/+/33812
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I3b4eda10e81a705aef8d647a860890a74cba8f13
Gerrit-Change-Number: 33812
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: mschramm <mschramm(a)sysmocom.de>
Gerrit-Reviewer: roh <jsteiger(a)sysmocom.de>
Gerrit-Attention: mschramm <mschramm(a)sysmocom.de>
Gerrit-Attention: roh <jsteiger(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Jul 2023 08:09:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment