Attention is currently required from: osmith, neels, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/29490
)
Change subject: osmux: Allocate rate counters during initialization of osmux conn
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/libosmo-mgcp/mgcp_osmux.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/29490/comment/7fbb516d_700a9700
PS1, Line 503: an conn
("a conn") […]
Ack
https://gerrit.osmocom.org/c/osmo-mgw/+/29490/comment/4db6502c_9885877a
PS1, Line 508: conn_osmux_allocate_local_cid
commit log says nothing about allocating the cid
earlier. […]
It's not being allocated earlier, the code is moved inside this
function and it's called at the same code path as below.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/29490
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic31d3567f4d24e628f8983d8362e5c7c2f66ec02
Gerrit-Change-Number: 29490
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 27 Sep 2022 12:05:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment