Attention is currently required from: falconia, laforge.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32078 )
Change subject: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case ......................................................................
Patch Set 1:
(2 comments)
File src/trau/trau_rtp_conv.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/32078/comment/89c42035_f31a6b87 PS1, Line 282: } else if (data_len == 0) { : /* C1 .. C5: idle speech */ : tf->c_bits[0] = 0; : tf->c_bits[1] = 1; : tf->c_bits[2] = 1; : tf->c_bits[3] = 1; : tf->c_bits[4] = 0;
Shouldn't this clause come before/independent of the UL/DL if/else clause? […]
i also wonder if it is intentional to indicate idle speech only for, which is it, DL? I guess if it can be a standalone 'if (data_len == 0)' condition acting on both DL and UL, that would already make the flow easier to read.
https://gerrit.osmocom.org/c/libosmo-abis/+/32078/comment/9bd5d1dd_8cb46b3f PS1, Line 441: if (data_len == 0 && tf->dir == OSMO_TRAU_DIR_DL) { (wondering as above: why only for DL?)