Attention is currently required from: jolly.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32930 )
Change subject: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions
......................................................................
Patch Set 1:
(1 comment)
File src/gsm/libosmogsm.map:
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/ab644932_c2c18b69
PS1, Line 474: gcc_msg_type_names;
Ideally, all new symbols should be prefixed with `osmo_`. The `gsm/protocol` directory is
a bit special and this rule is not really followed, but I would still suggest adding
`gsm44068_` prefix or something like that to avoid naming conflicts.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32930
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3554cea47e714c8fca18c3e9c0e6e80695915a90
Gerrit-Change-Number: 32930
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 23 May 2023 14:54:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment