Attention is currently required from: pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 )
Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on
socket files
......................................................................
Patch Set 5:
(1 comment)
File scripts/osmotestconfig.py:
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980/comment/6768e…
PS5, Line 80: ign = shutil.ignore_patterns('*.cfg',
'*tmp_dummy_sock')
It's the first time I actually realize the
existence of this socket. […]
So that would boil down to adding a new parameter to
`osmotestconfig.py` to account for ignores being passed up the call stack in the script,
plus changing the invocation of this script in each project to pass the socket file to be
ignored.
Maybe for now it's easier/quicker to just ignore the given file name since it's
not likely to change any time soon (?). Of course the parameter solution would be
cleaner.
--
To view, visit
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664
Gerrit-Change-Number: 30980
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 18 Feb 2023 18:02:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment