Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27936
)
Change subject: paging: Rework timer lifecycle logic
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
credit_timer is scheduled during paging_init(), when the BTS is started.
It is also re-scheduled every time paging_update_buffer_space() is called, that is, every
time a CCCH Load indication.
When credit_timer triggers (paging_give_credit()), paging_handle_pending_requests() is
called. However, after that, the timer is not rescheduled, so indeed in here we'd fail
to continue giving credit if no CCCH Load Ind is received anymore. Thanks for raising the
topic, I'll fix it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27936
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6a0da03c408270044079e81d431f6641527c00cd
Gerrit-Change-Number: 27936
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 27 Apr 2022 10:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment