21 Jun
2024
21 Jun
'24
4:42 p.m.
Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email )
Change subject: ttcn3-s1gw-test: fix using unassigned addr for osmo-s1gw
......................................................................
Patch Set 1:
(1 comment)
File ttcn3-s1gw-test/S1GW_Tests.cfg:
https://gerrit.osmocom.org/c/docker-playground/+/37270/comment/f8ee1812_1c8…
PS1, Line 10: S1GW_Tests.mp_s1gw_enb_ip := "172.18.10.100";
My understanding is of this patch is that since we
asked you drop the multiple interface changes to the docker setup, you decided to move
back to use the same IP address for both sides.
Ack.
It's fine to keep using the same IP address, but
if you really need/want to test with multiple addresses, you can do so in the docker setup
too, by adding an intermediate .sh script which does "ip addr add A.B.C.D".
This requires `iproute2` package, which is sadly missing in the base `docker` image and in
the `debian-bookworm-erlang` we build on top of it. I see you're installing it in
`osmo-epdg-master/Dockerfile`, and I could just do the same, but how about installing it
in `debian-bookworm-erlang` (in which we already install pkgs like `vim`, `netcat`,
`wget`)? Would you CR+ such a patch?
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37270?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I109a5feaca5acf050008e883cc8b4e1e28beebab
Gerrit-Change-Number: 37270
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Jun 2024 16:42:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment