Attention is currently required from: fixeria, jolly.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email )
Change subject: core: Add software UART implementation
......................................................................
Patch Set 3:
(1 comment)
File src/core/soft_uart.c:
https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/b08f4bd0_2bbe7a2e
PS3, Line 203: /* FIXME: Tx */
Ah, I actually wanted to clarify the idea behind this
function first. […]
enabling/disabling the receiver are completely orthogonal
functions to modem status lines (they also are completely independent in any hardware
UART). modem status lines tell you information like the state of the *attached*
equipment. Example: Is the data terminal ready (DTR)? Does the modem have a carrier?
(DCD). See V.110 and the table in
https://osmocom.org/projects/retronetworking/wiki/RS232_vs_ITU_V24_Signal_N… giving
"normal" names for those numeric circuit numbers in V.110
So basically all this function here would do is to set some state whcih then ends up in
the S/X-bits, and which is used by the remote end to replicate those status lines.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84
Gerrit-Change-Number: 30763
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Nov 2023 16:42:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment