[M] Change in osmo-sgsn[master]: GMM: split parsing of a RA Update Request in a separate file

Attention is currently required from: daniel, lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email ) Change subject: GMM: split parsing of a RA Update Request in a separate file ...................................................................... Patch Set 7: (4 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18009): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/d5fccd56_f7c1edc7?us… : PS7, Line 1624: LOGMMCTXP(LOGL_NOTICE, mmctx, "Update type %i unsupported in Mode III, is your SI13 corrupt?\n", req.update_type); Use %d instead of %i File src/sgsn/gprs_gmm_util.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18009): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/a3fd15d8_b7cb14e6?us… : PS7, Line 98: if (msgb_l3len(msg) < (len + (cur - msgb_gmmh(msg)))) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18009): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/d7468739_c8399467?us… : PS7, Line 108: if (msgb_l3len(msg) == mandatory_fields_len) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18009): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/e32a1295_80a35b72?us… : PS7, Line 115: if (ret < 0) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d Gerrit-Change-Number: 37869 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Attention: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-Comment-Date: Thu, 22 Aug 2024 11:14:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No