[M] Change in osmo-bsc[master]: pcu_sock: activate/deactivate PDCH on pcu reconnect

Attention is currently required from: neels, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31497 ) Change subject: pcu_sock: activate/deactivate PDCH on pcu reconnect ...................................................................... Patch Set 3: (9 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/a0d8dcdf_350f924a PS2, Line 10: po Done File doc/timeslot.msc: https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/692f83cc_73d3c2ba PS2, Line 95: bsc_ts abox bsc_ts [label="UNUSED"]; Thats true, Can we shorten this since the mechanism is already explained above. I have now added some dots in the graph to indicate that there is something in between. https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/872f8b9d_933f3141 PS2, Line 98: " Done https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/61358273_1c43b7c9 PS2, Line 99: PDCH Done https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/5f4e20a2_893985a0 PS2, Line 100: bsc_ts <- pcu_sock [label="TS_EV_PDCH_ACT"]; (see above: this can't be shortened.) File include/osmocom/bsc/timeslot_fsm.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/c1b8d803_179120eb PS2, Line 38: TS_EV_LCHAN_UNUSED, Done https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/2230b651_6106dd49 PS2, Line 42: TS_EV_PDCH_DEACT_NACK, Done https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/8bf192c0_9df3612f PS2, Line 43: TS_EV_PDCH_DEACT, Done File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/c5e97d03_1deb1545 PS2, Line 940: /* FIXME: allow multiple BTS */ That is correct. Thats also a limitation of the the PCU itsself. At some day we will have to resolve that but for the moment I think that no one will run an osmo-bsc setup with multiple ericsson BTS attached. Since the BTS is hooked up via an E1 line each site will likely get its own BSC on site, so I think there is no immediate pressure to fix this. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9ea0c53a5e68a51c781ef43bae71f947cdb95678 Gerrit-Change-Number: 31497 Gerrit-PatchSet: 3 Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 27 Feb 2023 19:46:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-MessageType: comment