Attention is currently required from: pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/27398 )
Change subject: usb: Match device by VID/PID without path/addr if it is unique
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
This looks a bit dangerous. […]
the current
problem is that you always have to specify either the address or the path for all the
simtrace tools. That's annoying as the address and path changes every time you plug
the device itno some other socket of your computer.
For all those users that only have a single simtrace connected, it is inconvenient having
to specify those parameters all the time.
Even with this patch the application must explicitly request this behavior by not
providing a path (strlen == 0) and by not providing an address (0). So any application
that specifies either a path or an address will not have the automatic selection.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/27398
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2ef245a56dfcf22758a0216b86d2a5c602ee5588
Gerrit-Change-Number: 27398
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Mar 2022 17:01:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment