[S] Change in osmo-ttcn3-hacks[master]: library/gsup: fix wrong IE order in f_gen_tr_ss_ies

Attention is currently required from: laforge, lynxis lazus. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email ) Change subject: library/gsup: fix wrong IE order in f_gen_tr_ss_ies ...................................................................... Patch Set 3: (1 comment) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586/comment/5a477918_0a41… : PS2, Line 1412: ies[idx] := *; Right. There's unfortunately no way to express that we optionally expect a specific kind of IE here, i.e. either OSMO_GSUP_MESSAGE_CLASS_IE or nothing. I tried several things: * a) `ies[idx] = tr_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_USSD) ifpresent` * b) `ies[idx] = (tr_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_USSD), omit)` * c) `ies[idx] = * length(0..1)` and none of this compiled. The a) used to work, but then was removed in TITAN [1]; the b) does not compile. The c) is permitted by the specs and would allow to at least limit number of IEs in this position (none or one), but TITAN does not implement this syntax [2]. [1] https://www.eclipse.org/forums/index.php/t/1103442/ [2] https://gitlab.eclipse.org/eclipse/titan/titan.core/-/issues/743 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5aafbc885d3b78fd37f84feebf5dab1255d51eb1 Gerrit-Change-Number: 38586 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Nov 2024 16:01:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>