Attention is currently required from: fixeria, osmith, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35134?usp=email )
Change subject: rlp: Add support for 576bit RLP frames ......................................................................
Patch Set 3:
(2 comments)
File src/gsm/rlp.c:
https://gerrit.osmocom.org/c/libosmocore/+/35134/comment/aafd05b9_812a024d PS3, Line 74: /* we only support 240 bit so far */
this is not true anymore?
Done
https://gerrit.osmocom.org/c/libosmocore/+/35134/comment/cb81046a_f26ced39 PS3, Line 88: out->fcs = (data[data_len-1] << 16) | (data[data_len-2]) << 8 | (data[data_len-3] << 0);
all this could really go into the previous commit.
yes, with the difference that the 240bit is actually tested while the 576 is not. I'd like to merge the 240bit code now and the 576bit later when I found devices and a working setup to actually verify it.