Attention is currently required from: fixeria.
Jenkins Builder has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-pcu/+/39778?usp=email )
Change subject: csn1: Use enum to select enc/dec direction
......................................................................
Patch Set 1:
(8 comments)
File src/csn1.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22068):
https://gerrit.osmocom.org/c/osmo-pcu/+/39778/comment/39e29943_d88de608?usp… :
PS1, Line 55: CSN_DIRECTION_ENC = 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22068):
https://gerrit.osmocom.org/c/osmo-pcu/+/39778/comment/7c664497_9037d2cf?usp… :
PS1, Line 56: CSN_DIRECTION_DEC = 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22068):
https://gerrit.osmocom.org/c/osmo-pcu/+/39778/comment/e53ca4d8_aae5661f?usp… :
PS1, Line 69: enum CSN_Direction direction; /* encode vs decode */
please, no spaces at the start of a line
File src/csn1.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22068):
https://gerrit.osmocom.org/c/osmo-pcu/+/39778/comment/4010936c_7ae1d450?usp… :
PS1, Line 76: ar->direction = CSN_DIRECTION_ENC;
please, no spaces at the start of a line
File src/csn1_dec.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22068):
https://gerrit.osmocom.org/c/osmo-pcu/+/39778/comment/e74ba6c5_65a800c7?usp… :
PS1, Line 486: arT.direction = CSN_DIRECTION_DEC;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22068):
https://gerrit.osmocom.org/c/osmo-pcu/+/39778/comment/166f7c02_d65173f7?usp… :
PS1, Line 486: arT.direction = CSN_DIRECTION_DEC;
please, no spaces at the start of a line
File src/csn1_enc.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22068):
https://gerrit.osmocom.org/c/osmo-pcu/+/39778/comment/57906aec_c82d8f1d?usp… :
PS1, Line 436: arT.direction = CSN_DIRECTION_ENC;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22068):
https://gerrit.osmocom.org/c/osmo-pcu/+/39778/comment/94888fba_3a7fe852?usp… :
PS1, Line 436: arT.direction = CSN_DIRECTION_ENC;
please, no spaces at the start of a line
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/39778?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I845bcab61e354436bff1c3a0f2b6f49de9705716
Gerrit-Change-Number: 39778
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Mar 2025 15:42:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No