[S] Change in osmo-bsc[master]: cosmetic: Clarify language ip.access nanoBTS vs. all IPA Abis/IP

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32180 ) Change subject: cosmetic: Clarify language ip.access nanoBTS vs. all IPA Abis/IP ...................................................................... Patch Set 2: -Code-Review (2 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32180/comment/236193e3_f776a414 PS2, Line 1318: if (!is_ipa_abisip_bts(bts) || is_osmobts(bts)) { I don't see `NM_MT_IPACC_RESTART` being handled in osmo-bts.git, so looks like it's a nanoBTS specific command. The condition is indeed weird, I think it should be just `bts->type == GSM_BTS_TYPE_NANOBTS`. File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32180/comment/529ab12f_6a328eb2 PS2, Line 1923: ipaccess nanoBTS I think the logging message is still correct, it's a workaround for some nanoBTS fw versions. Not sure why would you want to use this command for other Abis/IP models like osmo-bts. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I31696d9a21a799511741a561085686cfa0728f93 Gerrit-Change-Number: 32180 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 01 Apr 2023 11:01:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment