Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/30126
)
Change subject: [codecs filter] use filter result in Assignment
......................................................................
Patch Set 4:
(2 comments)
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/30126/comment/04057ece_68c8a16d
PS4, Line 1797: codec_filter_run(&trans->cc.codecs);
why does this need to be called here? I see no codec
being changed before it?
Previously we discussed that codec_filter_run() should be
called just before its result is used. That is what this is doing.
File src/libmsc/msc_a.c:
https://gerrit.osmocom.org/c/osmo-msc/+/30126/comment/48f430ac_38f53665
PS4, Line 1826: /* Make sure an MGW endpoint towards RAN is present, and when the RTP to
RAN is set up, an Assignment Request is
not sure what this comment is about. […]
yeah
i'm not sure either =)
I think it should be a lot shorter.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/30126
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I66e7c8c5e401f4f3a7d3d42b9525b2c6e99691d9
Gerrit-Change-Number: 30126
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Mar 2023 16:48:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment