Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/29372
)
Change subject: ipaccess-config: Initiate missing IPA osmo_link
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/osmo-bsc/bts_ipaccess_nanobts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29372/comment/96d1b1fc_e9bc7eda
PS1, Line 619: OSMO_ASSERT(bts->osmo_link);
would it make sense to assert this earlier, while
using the link, not only when dropping it?
the interesting path here is when
dropping it, since other apps may not use it. The main problem here really is
ipaccess-config reimplementing all the lowest ipa parts with its own fake code while still
hooking in some middle-layer parts.
But rewritting that is totally out of the scope of this patchset.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/29372
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3f63f6827f7c5d7a21ac125b7ca6b35244efbb65
Gerrit-Change-Number: 29372
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Sep 2022 14:06:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment