Attention is currently required from: osmith.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/gapk/+/34892?usp=email )
Change subject: dist: exclude libgsmhr files downloaded by fetch_sources.py
......................................................................
Patch Set 1:
(1 comment)
File libgsmhr/Makefile.am:
https://gerrit.osmocom.org/c/gapk/+/34892/comment/e376410c_57907fd1
PS1, Line 39: -rm -rf $(distdir)/$(REFSRC_PATH)
However downloading the sources first even if we
don't intend to package them, and then remove them, seems like an unclean solution.
Can't we additionally change it so they don't get downloaded in the first place
unless --enable-gsmhr is set?
I was thinking of this and first tried to make the autotools not download these files, but
could not find any hooks nor examples for that. Maybe this can be achieved by overwriting
the `distdir-am` target somehow, but then we would need to manually add these files which
need to be in the tarball. I gave up on this.
--
To view, visit
https://gerrit.osmocom.org/c/gapk/+/34892?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Change-Id: I66e31dec37e53bf1a8c7df948fd9316e1467752c
Gerrit-Change-Number: 34892
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Oct 2023 13:05:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment