Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32931 )
Change subject: ASCI: Add IE transcoding according to 3GPP TS 48.008
......................................................................
Patch Set 1:
(5 comments)
File include/osmocom/gsm/gsm0808_utils.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7263):
https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/0b885944_2087ad07
PS1, Line 437: const struct gsm0808_cell_id_list_segment *ci);
code indent should use tabs where possible
File src/gsm/gsm0808_utils.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7263):
https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/301a1544_6c920b5c
PS1, Line 2472: if (rc <= 0)
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7263):
https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/c3bd6b63_240d5249
PS1, Line 2472: if (rc <= 0)
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7263):
https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/9b0df538_8f70d7bd
PS1, Line 2473: return rc;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7263):
https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/1d7a1111_db39990b
PS1, Line 2473: return rc;
please, no spaces at the start of a line
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32931
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd
Gerrit-Change-Number: 32931
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 23 May 2023 14:05:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment