Attention is currently required from: neels, pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 )
Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on
socket files
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Having each python app/file creating those specific
files register them to be cleaned up, and not be […]
In general, I'm always for
fixing things the 'proper' way. But the way it looks, nobody is going to change
those socket file names any time soon. And then, still, that alone still wouldn't
break anything. Doing what you describe would take a lot more time vs. this which is a
quick fix that doesn't complicate anything/could be built upon when writing a
'proper' fix (by replacing the string literal with whatever is passed by the
respective test component)
--
To view, visit
https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664
Gerrit-Change-Number: 30980
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 26 Mar 2023 19:52:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment