Attention is currently required from: Hoernchen.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/32762 )
Change subject: transceiver: pass cfg struct instead of args
......................................................................
Patch Set 3:
(4 comments)
File Transceiver52M/device/lms/LMSDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/5909bfff_7fb9c9fd
PS3, Line 110: LMSDevice(InterfaceType iface, const struct trx_cfg *cfg);
tabs vs spaces inconsistency
File Transceiver52M/device/uhd/UHDDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/26d4469d_9ed25620
PS3, Line 83: uhd_device(InterfaceType iface, const struct trx_cfg *cfg);
tabs vs spaces inconsistency
File Transceiver52M/device/usrp1/USRPDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/20dbbf00_a199214c
PS3, Line 107: USRPDevice(InterfaceType iface, const struct trx_cfg *cfg);
2 spaces vs 4 spaces inconsistency?
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/5289a907_7df81c9f
PS3, Line 120: return TX_WINDOW_USRP1;
what a mix
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/32762
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I48386900d15ff4d770c70a4efc246d32f921904b
Gerrit-Change-Number: 32762
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 20 May 2023 08:13:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment