Change in osmo-bts[master]: measurement: fix matching of SUB frames by TDMA FN

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/28086 ) Change subject: measurement: fix matching of SUB frames by TDMA FN ...................................................................... Patch Set 1: (3 comments) File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/28086/comment/96cb455c_8d48a5cc PS1, Line 23: /* TCH/H(0): 0, 2, 4, 6, 52, 54, 56, 58 */ In this comment it's just a set of FNs copied from 3GPP TS 45.008 as-is. Blocks with the respective FNs they consist of are listed below this comment. I don't think a semicolon makes sense here. https://gerrit.osmocom.org/c/osmo-bts/+/28086/comment/fd642245_a8d7b4af PS1, Line 26: /* TCH/H(1): 14, 16, 18, 20, 66, 68, 70, 72 */ Same here, blocks are listed below. This is one-to-one copy from 3GPP TS 45.008. https://gerrit.osmocom.org/c/osmo-bts/+/28086/comment/ac4879d4_c7c4c3ec PS1, Line 65: * There is only one *complete* block in this subset starting at FN=52. The first FN of incomplete block {52, 53, 54, 55} is actually several FNs earlier, because on TCH/F every block is interleaved over 8 consecutive bursts. But in DTXu mode, the MS does not transmit the first 4 bursts - that's why I am not listing them in square brackets. Maybe saying {... 52, 53, 54, 55} and {56, 57, 58, 59 ...} would make it cleaner? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/28086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8cc3a755a8ad4dc564439aab2298c1e97ac0592d Gerrit-Change-Number: 28086 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 May 2022 13:26:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment