Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32194
)
Change subject: nm: Apply BTS/TRX/TS OML Attributes through NM FSMs
......................................................................
Patch Set 2:
(1 comment)
File src/common/nm_bb_transc_fsm.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32194/comment/0f953697_6ee88442
PS2, Line 132: (struct abis_om_fom_hdr *)msgb_l3(setattr_data->msg))->msg_type
yes I can do so. […]
Marking this patch as WIP
since actually in here there may be a change in behavior, because I think oml_fom_ack_nack
keeps the content of the originating message when transmitting the ACK.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32194
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id68868e25bbf96227ab6459fcd3c9181852ed28e
Gerrit-Change-Number: 32194
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 04 Apr 2023 18:28:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment