Attention is currently required from: fixeria.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/1627 )
Change subject: tests/conv: separate test logic
......................................................................
Patch Set 4:
(1 comment)
File tests/conv/conv.c:
https://gerrit.osmocom.org/c/libosmocore/+/1627/comment/3b36aa63_b62c15f9
PS4, Line 42: return -1;
I suppose we don't care too much about memleaks here, because it's the test main function anyways? Coverity created some reports for this file, I think we can ignore those but I thought I'd check just in case
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/1627
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idbdc7e19cb9b9a36cd1fccd621cd858e87530d98
Gerrit-Change-Number: 1627
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: tnt
tnt@246tNt.com
Gerrit-CC: arehbein
arehbein@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Sun, 26 Mar 2023 19:49:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment