Change in osmo-bsc[master]: stats: new trackers for lchan life duration (v2)

Attention is currently required from: neels, pespin. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28165 ) Change subject: stats: new trackers for lchan life duration (v2) ...................................................................... Patch Set 2: (4 comments) Patchset: PS2: Hi all, I measured 20 minutes worth of performance data (in nsecs) from this and the other global BSC timers for comparison. This is on a BSC with 82 active BTS, 4500 SDCCH and 3200 TCH/H defined. During the measurement, 800-1000 SDCCH and 450-600 TCH/H were active at any given time. @hist_update_t3122_chan_load_timer: [4K, 8K) 13 | | [8K, 16K) 21 |@ | [16K, 32K) 16 | | [32K, 64K) 2 | | [64K, 128K) 3 | | [128K, 256K) 331 |@@@@@@@@@@@@@@@@@@@@ | [256K, 512K) 836 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@| [512K, 1M) 48 |@@ | @hist_bsc_store_bts_uptime: [16K, 32K) 88 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@| [32K, 64K) 35 |@@@@@@@@@@@@@@@@@@@@ | [64K, 128K) 4 |@@ | @hist_bsc_store_bts_lchan_durations: [4K, 8K) 9 | | [8K, 16K) 10 | | [16K, 32K) 31 |@ | [32K, 64K) 2 | | [64K, 128K) 0 | | [128K, 256K) 6 | | [256K, 512K) 1208 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@| [512K, 1M) 2 | | [1M, 2M) 0 | | [2M, 4M) 2 | | I still have an accuracy problem to work out as it seems uninitialized (active_stored) values are being used causing huge leaps in duration. Let me know if this performance impact seems acceptable. To me, it looks a bit heavier than the t3122 management but not by much. Thanks, -Michael File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/f2e0f557_3842c764 PS1, Line 768: if (!lchan->activate.concluded) Done https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/8bb82c1e_ff1b6cdf PS1, Line 772: timespecsub(&now, &lchan->active_stored, &elapsed); I believe more checks are needed. In testing on a fully loaded system, I see some massive durations being sent which makes me think we're reaching this point but active_stored hasn't yet been initialized. File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/ddd011c5_06603de7 PS1, Line 574: vty_out(vty, " Activated %s seconds ago%s", Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie3771233ecbd4bc24a24fb22c1064a18e7b8b2b0 Gerrit-Change-Number: 28165 Gerrit-PatchSet: 2 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 May 2022 11:05:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment