Attention is currently required from: laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39670?usp=email )
Change subject: filesystem: do not decode short TransRecEF records ......................................................................
Patch Set 3:
(1 comment)
File pySim/filesystem.py:
https://gerrit.osmocom.org/c/pysim/+/39670/comment/f8cd1c89_e1f07128?usp=ema... : PS3, Line 1231: if len(raw_hex_data) // 2 < self.__get_rec_len():
I would think this is too harsh. […]
I think I don't get what you mean by that. The too-short trailer is output as raw data (e.g. {"raw": "ffffffff"}). So technically it is treated as invalid data.
Or do you mean the decoder function should do the check and sort out any invalid input? In this case that would be utils:dec_xplmn_w_act.
(I am not aware of an explicit specification that TransRecEFs must always have a length that is a multiple of the record length, however it would make sense.)