[L] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... Patch Set 1: (219 comments) File src/gsm/tuak/KeccakP-1600-3gpp.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f3b8d1e0_5e27ea52 PS1, Line 22: EXPORTIT void Keccak_f_8 (uint8_t s[200]); space prohibited between function name and open parenthesis '(' File src/gsm/tuak/KeccakP-1600-3gpp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7dc33c4a_746012e3 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/757f45a9_69c4b0af PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/07b106a2_af39c92f PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73247bdf_839cc400 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f28ea848_f8c2586a PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/030f23d3_f9f8ef64 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c209d1a1_5fb651ea PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/21c031ce_496ee7e7 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0462ff7e_dc679892 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a3e9c299_948bb2e1 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9612e708_6dd497d4 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cf30f296_156a5e12 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/754bb38b_5d181e6a PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/404fb88e_9d6643f6 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/04324f2a_dc9bde88 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/55928e8e_7e011d4a PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c15449c8_ef48579a PS1, Line 13: 15,21,8,18,2,61,56,14}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6c83cd4b_0f772a1d PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/51a911e3_6b2d8c9c PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9d66690c_b3103aac PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/112daa73_7eb19f7d PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e35f7957_e22d8e93 PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0953e248_f58487b7 PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f8ee3625_9c3a92f8 PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b350d859_040eae68 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c27e59ac_9014e3ef PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89e91b72_ac90505a PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f4a329c2_6b8f48d6 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/96d22e24_812ed4fd PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e0ff439f_56a2b7b1 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3b31003b_2048937a PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3de67bd1_fc82b816 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05eeeaba_db6f6468 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73b40b93_f948572d PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5aa39f18_e8cd3cf0 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ff11c797_ed763063 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/674d3ed9_f143b93f PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c9759366_f2e04841 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1eeab0a2_d84d0a61 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6fae07eb_c98efb1d PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a1e4bb6b_ac2b10d5 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e35e3ec1_aa0d01f8 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0ac97784_db0dd849 PS1, Line 16: 23,2,8,14,15,21}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3fae5ef3_3ba20421 PS1, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dbe2128a_af19463f PS1, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5f36bdcb_749991f1 PS1, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dffa2310_dbdc1276 PS1, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9e967695_6b6205c8 PS1, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/58877e82_94065a53 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/792ae0aa_7419ab64 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e0141e27_67184e8a PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d15f42a4_4bf67ddf PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a11309b8_393f0e83 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/609fc71a_f82c6c9d PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d5662588_7fc8b806 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ee3c91a6_d017743f PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73b9ff8f_923f9cbe PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/62eeec7e_56014dc9 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2a233a4b_f4e2e703 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dd3bd91f_445b82eb PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0a2815fc_1786d382 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e9cc40f9_af742b4d PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cf725397_e1b2c095 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8bc58c87_897c7d5d PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d819edc2_7d69f3a5 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0e54e0d1_40197029 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/62bbfc0b_0163f8c7 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/598d36d7_220a498d PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6e03ae9a_bb567086 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ed5cbe95_ade2251c PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/15bb6d5e_190482a5 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c4488d2e_9c656296 PS1, Line 32: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6c70a095_18062b8f PS1, Line 32: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/03b3b082_3e8777ca PS1, Line 32: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cfb7e855_f6063c9b PS1, Line 32: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/12a43180_6aaeaf9b PS1, Line 34: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d0bad51c_2d0069eb PS1, Line 34: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f79c69a9_708a2d45 PS1, Line 34: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/382ee4ca_802e9212 PS1, Line 36: for(i=0; i<5; ++i, s+=5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/feee4265_f1ac35b6 PS1, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a3e065ef_c511acbd PS1, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/62ac3c64_6fe1b192 PS1, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d4523e41_2d5d5540 PS1, Line 36: for(i=0; i<5; ++i, s+=5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/17d6a4c1_edbd05b4 PS1, Line 46: for(i=1; i<25; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f8615300_cc054279 PS1, Line 46: for(i=1; i<25; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a96699d5_16a7f973 PS1, Line 46: for(i=1; i<25; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/897036fd_d9e22128 PS1, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/51713854_5f39733c PS1, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/61f3ca9e_722b31a4 PS1, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9841cd22_227cdc92 PS1, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cc88af27_f9c99386 PS1, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/34d63388_61ecf5cb PS1, Line 54: for(i=0; i<5; ++i, s += 5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/754a663f_92f2939c PS1, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e067fb41_e4ea4980 PS1, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2202155e_ff371bcc PS1, Line 54: for(i=0; i<5; ++i, s += 5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/25e87938_ee5a7aae PS1, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7273bf24_38d9d7cb PS1, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2466abce_91584bc2 PS1, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4c09aee9_e8bc62f7 PS1, Line 66: *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57)) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/17c8cd28_ebddbd2f PS1, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2febb03e_ef9ab386 PS1, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5d763390_be25e892 PS1, Line 79: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5edf2d12_68f72728 PS1, Line 79: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a85e2a80_d6801209 PS1, Line 79: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0d553eb2_6f4d6bd7 PS1, Line 79: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/297dacf8_3f824a08 PS1, Line 81: for(i=0; i<40; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d37053f8_8cf0d428 PS1, Line 81: for(i=0; i<40; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/43043d55_ce304e5d PS1, Line 81: for(i=0; i<40; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f76cfbd9_4e8a5ef8 PS1, Line 82: t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ba9cbffc_6fb84c7b PS1, Line 83: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/639c54cf_a6b7651f PS1, Line 83: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f77935b7_06d001c0 PS1, Line 83: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2f27338b_d88926bd PS1, Line 83: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bf4c8660_71471e62 PS1, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/554f98ca_b365fc2c PS1, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d4a5420b_7063927f PS1, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0ad9b70e_250b0ea5 PS1, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/17d52b6a_3e324d79 PS1, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/212da08a_73df4134 PS1, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/592b45d4_ac3614cb PS1, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/55647a35_c004c2a0 PS1, Line 87: for(j = t[i+7]>>7, k=7; k; --k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ccbe98cf_dade123b PS1, Line 87: for(j = t[i+7]>>7, k=7; k; --k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/08055971_06e12db8 PS1, Line 89: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ca3c3e5e_32ab6c3b PS1, Line 89: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fac373a1_aefa0152 PS1, Line 89: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ef606eb8_46d08af5 PS1, Line 89: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/923c5554_b02cdc1f PS1, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b8539003_e392e09b PS1, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0c26f48f_135cb738 PS1, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8928e99d_2de00623 PS1, Line 94: for(i=8; i<200; i+=8) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b1baf1ca_95a9eab0 PS1, Line 94: for(i=8; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8742a7d7_4ff2206a PS1, Line 94: for(i=8; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a227d888_726ce3e9 PS1, Line 94: for(i=8; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aedf773b_e769c1e1 PS1, Line 94: for(i=8; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bbf17597_30234731 PS1, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f55172c8_a9c9263f PS1, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/18c3fee2_5ea2ee0e PS1, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e2cf4c0_7e23a248 PS1, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/982e587b_6ccbe62b PS1, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/623b5824_accc9bf2 PS1, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/27a662a8_ef3e0a20 PS1, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6d81455a_b63bf564 PS1, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2476f270_7894a365 PS1, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5434ac98_93d99c9c PS1, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1b988677_18fc8dd1 PS1, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c82a6b95_e469b8ff PS1, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b10fe8ad_de10bb0f PS1, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/26108463_3b88c512 PS1, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0b0161d5_8625895a PS1, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f9195a92_f71af1ab PS1, Line 104: for(i=1; (j=Pi[i])>1; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/edefbc08_c78779de PS1, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/582069cd_62225ca2 PS1, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2e36acad_cbd03d04 PS1, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2ae58c15_388565d5 PS1, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3edea6f8_b02f9b2b PS1, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/93f2750d_9813e0b4 PS1, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b2a6e95_07cbb2e4 PS1, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/62854cff_0249a7dc PS1, Line 111: for(i=0; i<200; i+=40) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5475652e_c3c42e5d PS1, Line 111: for(i=0; i<200; i+=40) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6560813_a77b933c PS1, Line 111: for(i=0; i<200; i+=40) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/15e9188e_9fc31d82 PS1, Line 111: for(i=0; i<200; i+=40) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5e955ced_2cfe48e6 PS1, Line 111: for(i=0; i<200; i+=40) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f2650234_ca7d6db9 PS1, Line 112: { for(j=0; j<40; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e138cc59_5b67d1ac PS1, Line 112: { for(j=0; j<40; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e185dba1_e3c206c6 PS1, Line 112: { for(j=0; j<40; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ad1168e4_95ab44b1 PS1, Line 113: t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/22a455ad_92a46910 PS1, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d38de161_df903c57 PS1, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e25eac71_6e5a9104 PS1, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '^=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/51bdfc6e_0d828d36 PS1, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/33dfc159_eddd0e41 PS1, Line 135: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f7eea16b_7c7a0de7 PS1, Line 135: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0fcba008_89ab4aa8 PS1, Line 135: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2674b5d1_74c9a63c PS1, Line 135: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ea8d6909_4e03a224 PS1, Line 137: for(i=0; i<10; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9fc49334_bbebf1c2 PS1, Line 137: for(i=0; i<10; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/892f45a9_3d1f137d PS1, Line 137: for(i=0; i<10; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d5beb347_2680c591 PS1, Line 139: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/58d87c9e_6738b7e6 PS1, Line 139: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/871ecf3a_43f6fc35 PS1, Line 139: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4307b4b4_34d576df PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/31ffb6d3_fbc0eeeb PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3d80e8ab_0f90c4f1 PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9215db49_8fd6395a PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '%=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/84004300_01191abb PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b76a4fee_80e9269d PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4c346d99_3798e16b PS1, Line 143: if(j==8) break; spaces required around that '==' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/98f743f2_24e27d64 PS1, Line 143: if(j==8) break; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/007ba90e_1ec15259 PS1, Line 148: for(i=2; i<50; i+=2) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/72940d44_6f1e2511 PS1, Line 148: for(i=2; i<50; i+=2) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b22686e0_e75e0d69 PS1, Line 148: for(i=2; i<50; i+=2) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/56441273_550037cc PS1, Line 148: for(i=2; i<50; i+=2) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e3152604_361b505a PS1, Line 148: for(i=2; i<50; i+=2) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a3fff000_c19c75f0 PS1, Line 153: s[i] = t[1-k], s[i+1] = t[k]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/105cbb0e_7a52dfb7 PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c0f23805_fb83c81c PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/863c4a96_8e987f4e PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/27f560b0_e0c59992 PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9917076a_8da91967 PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/96d52394_9818d213 PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/eeae03e8_5c0a83ee PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/69c411da_9830e973 PS1, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b3322a9e_6ffde01e PS1, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4ef71efd_6df13d8c PS1, Line 158: s[i]=s[j], s[i+1]=s[j+1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05a6c5ec_ef657e03 PS1, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0e52014e_4252b2fa PS1, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92dbd9b0_f92dd6c4 PS1, Line 159: s[i]=t[0], s[i+1]=t[1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/793c507a_501905bc PS1, Line 162: for(i=0; i<5; ++i, s+=10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f3d4bcdc_48d8688b PS1, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92523332_d43ddd34 PS1, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a2781d7e_5a534ccf PS1, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4c30890b_5e459e2a PS1, Line 162: for(i=0; i<5; ++i, s+=10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bb1f4286_39629ee3 PS1, Line 163: { for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/53bb6f3e_56889cc4 PS1, Line 163: { for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/50165c48_60161a18 PS1, Line 163: { for(j=0; j<10; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/41fb2922_1583ef2c PS1, Line 165: for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6c0856ac_8ca6b1ca PS1, Line 165: for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9e9db5b7_a7ea6a19 PS1, Line 165: for(j=0; j<10; ++j) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 1 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 30 May 2023 14:25:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment