21 Dec
2022
21 Dec
'22
8:03 p.m.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/30757 )
Change subject: Introduce utils/osmo-amr-inspect program
......................................................................
Patch Set 1:
(5 comments)
File utils/osmo-amr-inspect.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2189):
https://gerrit.osmocom.org/c/libosmo-netif/+/30757/comment/cb50c224_fbaa1efb
PS1, Line 69: printf( " Payload (%lu bytes): %s\n",
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2189):
https://gerrit.osmocom.org/c/libosmo-netif/+/30757/comment/966bba87_5c04e864
PS1, Line 113: printf( " Payload continuation (%lu bytes): %s\n", buf_len -
sizeof(*hdr),
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2189):
https://gerrit.osmocom.org/c/libosmo-netif/+/30757/comment/52d8a7c3_152dd0de
PS1, Line 145: printf( " Payload (octet-aligned %d bytes): %s", rc,
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2189):
https://gerrit.osmocom.org/c/libosmo-netif/+/30757/comment/3b28a4dd_efef5b14
PS1, Line 187: FILE * fp;
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2189):
https://gerrit.osmocom.org/c/libosmo-netif/+/30757/comment/4d51bdc6_064f8820
PS1, Line 188: char * line = NULL;
"foo * bar" should be "foo *bar"
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30757
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Iffa6cc2e5391b77e3097d4c3b8d3f5211427dbe2
Gerrit-Change-Number: 30757
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 21 Dec 2022 19:03:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment