[M] Change in libosmo-abis[master]: TRAU->RTP: add support for TW-TS-001 & TW-TS-002

Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email ) Change subject: TRAU->RTP: add support for TW-TS-001 & TW-TS-002 ...................................................................... Patch Set 1: (2 comments) File include/osmocom/trau/trau_rtp.h: https://gerrit.osmocom.org/c/libosmo-abis/+/37156/comment/34b9213b_f1df7414 PS1, Line 27: uint8_t rtp_extensions; Will add in the next patch iteration. File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/37156/comment/e58b258c_38ed80dc PS1, Line 291: crc_bfi = true; With TW-TS-001 it is now possible to emit BFI-with-data in RTP, just like in TRAU-UL frames. In the case of EFR, if the CRC is good but C12 is set (BTS emitted BFI marker, rather than transmission errors on Abis), we emit BFI-with-data in RTP: the whole point of TW-TS-001, aside from preserving TAF bit. Now the question is: if the TRAU-UL frame came in with CRC errors, should we also emit BFI-with-data, or emit a No_Data frame? TW-TS-001 allows either option: see Annex C in the spec. However, when I wrote TW-TS-002 spec for HR codec, I specified (section 6.2.3) that bad CRC-3 in the TRAU frame shall result in No_Data output. Hence thinking about it now, I'll make the EFR case consistent. I also just noticed that my code is currently plain-broken here in that I don't actually set the BFI bit in the TEH octet - will fix. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a6d13d406484c01210594bb6d2f0aff7c1341ab Gerrit-Change-Number: 37156 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jun 2024 16:34:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment