Attention is currently required from: fixeria, jolly.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email )
Change subject: soft_uart: add unit tests for the receiver and transmitter
......................................................................
Patch Set 4:
(9 comments)
File tests/soft_uart/soft_uart_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476):
https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/a730edf7_1f35bb69
PS4, Line 111: "F" /* flush! (for sanity) */ );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476):
https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/236c1092_b5f1f17d
PS4, Line 124: "0 11110010 1F" /* 'O', flush! */ );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476):
https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/40377751_0765055f
PS4, Line 131: "F" /* flush! */ );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476):
https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/ddb642ce_09509596
PS4, Line 144: "0 11110010 1F1F" /* 'O', flush! */ );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476):
https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/ddf1eb91_ef3ca6fc
PS4, Line 152: "F" /* flush! (for sanity) */ );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476):
https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/531fcf81_65585460
PS4, Line 163: "F" /* flush! (for sanity) */ );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476):
https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/a2f5d5e0_d385e982
PS4, Line 175: "F" /* flush! */ );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476):
https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/8af0b194_f609e1a9
PS4, Line 185: "F" /* flush! (for sanity) */ );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12476):
https://gerrit.osmocom.org/c/libosmocore/+/35046/comment/3b6fdfd4_a4f1c7f6
PS4, Line 197: "F" /* flush! */ );
space prohibited before that close parenthesis ')'
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19
Gerrit-Change-Number: 35046
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 19 Nov 2023 11:03:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment