neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27373 )
Change subject: support "empty" SCCP N-Connect from MSC ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: @osmith I think this linter complaint might be a candidate for dropping the linter rule:
"src/osmo-bsc/net_init.c:74: ERROR:SPACING: space required before that '-' (ctx:OxV)"
See osmo-bsc net_init.c, in struct value definitions we like to omit the spaces:
{ .T=-25, .default_val=5, .desc="Timeout for initial user data after an MSC initiated an SCCP connection to the BSS" },
Apparently it is only complaining about the ".T=-25" even though there are lots of other unspaced '='.
I ran s/([^ ])=([^ ])/\1 = \2/g on that code, but the result looks more noisy to me than unspaced '='.
(It seems this linter rule has lead to inconsistent style, some of those timer definitions have spaces and some don't. See https://git.osmocom.org/osmo-bsc/tree/src/osmo-bsc/net_init.c#n59 )
I assume it's not possible to apply the linter rule only outside of struct value definitions?